fix(compiler-cli): report all diagnostic error messages #19886
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes a problem introduced in 8d45fef which modified how diagnostic error messages are reported for structural metadata errors causing some of the diagnostics to be lost.
chuckjaz
added
area: core
|
You can preview 4e65960 at https://pr19886-4e65960.ngbuilds.io/. |
tbosch
approved these changes
Oct 24, 2017
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a problem introduced in 8d45fef
which modified how diagnostic error messages are reported for structural
metadata errors causing some of the diagnostics to be lost.
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Not all errors where reported when a structural error causes a cascading metadata validation error.
What is the new behavior?
All error errors are reported.
Does this PR introduce a breaking change?